Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link color contrast for darkmode #125

Open
reggi opened this issue May 16, 2024 · 3 comments
Open

Fix link color contrast for darkmode #125

reggi opened this issue May 16, 2024 · 3 comments
Assignees
@ninjaofawesome

Comments

@reggi
Copy link
Collaborator

reggi commented May 16, 2024

textarea

Screenshot 2024-05-15 at 9 33 39 PM
@ninjaofawesome
Copy link
Collaborator

I can take this one, it's related to the theming. What contrast ratio are you going for here? 3:1?

@reggi reggi changed the title Fix link contrast for darkmode Fix link color contrast for darkmode May 17, 2024
@reggi
Copy link
Collaborator Author

reggi commented May 17, 2024

@ninjaofawesome I think most accessibility checkers have it at 7:1 i'm using this one here https://webaim.org/resources/contrastchecker/

@ninjaofawesome ninjaofawesome self-assigned this May 20, 2024
@ninjaofawesome
Copy link
Collaborator

@ninjaofawesome I think most accessibility checkers have it at 7:1 i'm using this one here https://webaim.org/resources/contrastchecker/

Cool, I'll check it out!

@ninjaofawesome ninjaofawesome mentioned this issue May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ninjaofawesome ninjaofawesome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reggi @ninjaofawesome