Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add infer_batch_size to AllenNLPProcessor #8

Merged
merged 6 commits into from
Apr 6, 2021
Merged

add infer_batch_size to AllenNLPProcessor #8

merged 6 commits into from
Apr 6, 2021

Conversation

DianLiI
Copy link
Collaborator

@DianLiI DianLiI commented Apr 5, 2021

This PR fixes [#4].

Description of changes

Add config option infer_batch_size in case there are too many sentences.

Possible influences of this PR.

N/A

Test Conducted

Pipeline containing AllenNLPProcessor.

@DianLiI DianLiI requested a review from hunterhector April 5, 2021 22:19
hunterhector
hunterhector reviewed Apr 6, 2021
View reviewed changes
Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be nice to setup some type annotations.

forte_wrapper/allennlp/allennlp_processors.py Outdated Show resolved Hide resolved
@DianLiI DianLiI marked this pull request as draft April 6, 2021 14:53
@DianLiI DianLiI force-pushed the infer-batch-size branch from 3eae958 to ce4b180 Compare April 6, 2021 15:39
@DianLiI DianLiI marked this pull request as ready for review April 6, 2021 15:39
DianLiI added 3 commits April 6, 2021 11:43
@DianLiI
fix build
0b4230e
@DianLiI
Merge remote-tracking branch 'upstream/main' into infer-batch-size
52d1c51 
# Conflicts:
#	forte_wrapper/allennlp/allennlp_processors.py
#	setup.py
@DianLiI
fix lint
1ab008d
hunterhector
hunterhector previously approved these changes Apr 6, 2021
View reviewed changes
@hunterhector hunterhector dismissed their stale review April 6, 2021 20:22

find a documentation issue.

@hunterhector hunterhector merged commit b42b7aa into asyml:main Apr 6, 2021
@DianLiI DianLiI deleted the infer-batch-size branch April 6, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hunterhector hunterhector hunterhector approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DianLiI @hunterhector