-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ticket section render issue using slider component #478
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toffee-k21 the tickets are breaking in the on compressed view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add a test in the cypress test suite, for the changes you have made.
Hey @ashmit-coder, I have made the changes you suggested and also added Cypress tests for the changes I made. Additionally, there was an issue with the overflow of the slider component, which I have fixed. Below is the video regarding that ScreenRec_2024-11-28.18-03-55.mp4ScreenRec_2024-11-28.19-12-48.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work @toffee-k21, few suggested changes
- I noticed the venues on the landing is aligned to the left on desktop view
- I think you should remove the description in the ticket card and just keep it simple
…site into add/feat-add-render
…onference-website into add/feat-add-render
Thanks @AceTheCreator for your feedback, I have implemented what you suggested. Let me know if there's anything else you'd like me to adjust! |
Description
fixes #395
fixed card rendering issue in the Ticket section