Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Save" fails #25

Open
coinop-logan opened this issue Apr 10, 2020 · 5 comments
Open

"Save" fails #25

coinop-logan opened this issue Apr 10, 2020 · 5 comments
Assignees

Comments

@coinop-logan
Copy link

On Firefox. I loaded the one you built for SmokeSignal, then posted to SmokeSignal, then rearranged it a bit. Much to my dismay I couldn't seem to save it at all! Clicking save has no visual effect at all.

Console output upon clicking save:

1716578f597 0ms Starting document clone 2.3ee5998b.chunk.js:1:6701788
1716578f597 539ms Document cloned, using computed rendering 2.3ee5998b.chunk.js:1:6701788
1716578f597 539ms Starting DOM parsing 2.3ee5998b.chunk.js:1:6701788
1716578f597 595ms Added image data:image/svg+xml,%3Csvg%20xmlns%3D%22http%3A%2F%2Fwww.w3.org%2F2000%2Fsvg%22%20style%3D%22width%3A%2024px%3B%20height%3A%2024px%3B%20opacity%3A%200.95%3B%22%20viewBox%3D%220%200%2024%2024%22%20class%3D%22%22%20title%3D%22Scan%22%3E%3Cpath%20fill%3D%22%23 2.3ee5998b.chunk.js:1:6701788
1716578f597 660ms Starting renderer 2.3ee5998b.chunk.js:1:6701788
NS_ERROR_FAILURE 2.3ee5998b.chunk.js:1
@pi0neerpat
Copy link
Collaborator

Also experiencing this issue
Firefoz for Ubuntu v81.0

@Aragar199
Copy link
Contributor

Able to reproduce the error on firefox. Looks like it has to do with html2canvas niklasvh/html2canvas#2046
Looking in to it.

@Aragar199
Copy link
Contributor

Was not able to fix, but I did test some things that did not work:

  • hard code the rendered image to a smaller size, sometimes canvas draw doesn't work if the image is larger than the browser window limitations
  • update html2canvas to the latest version 1.3.1
  • added "allowTaint:true" flag to see if it was an issue with cross domain rendering
  • tried rendering jpg instead of img

Going to have to move on to other issues for now. If someone else wants to take a crack at this, feel free.

@grahamtallen grahamtallen self-assigned this Aug 16, 2021
@grahamtallen
Copy link
Collaborator

I'll take a look this week

@programmer-ke
Copy link

@grahamtallen were you able to look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants