Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gci order is incorrect for blank-import from local module #65

Open
ARR4N opened this issue Oct 28, 2024 · 2 comments
Open

gci order is incorrect for blank-import from local module #65

ARR4N opened this issue Oct 28, 2024 · 2 comments

Comments

@ARR4N
Copy link
Collaborator

ARR4N commented Oct 28, 2024

This should be in a separate block at the bottom.

_ "github.com/ava-labs/libevm/eth/tracers/native"

@ARR4N ARR4N added the Category: Bug 🐛 Something isn't working label Oct 28, 2024
@ARR4N ARR4N self-assigned this Oct 28, 2024
@qdm12
Copy link
Collaborator

qdm12 commented Dec 12, 2024

Indeed the gci linter used doesn't seem to apply the import sections order defined, where blank imports should be the last section. On the other hand, is there a reason we would want this? Maybe to deal with various init() functions? 🤔

@ARR4N
Copy link
Collaborator Author

ARR4N commented Dec 13, 2024

is there a reason we would want this?

Since underscore imports are for side effects and they're the only place in the code that you see it, I prefer to put them at the end as a way to call attention to them. It's not a high priority at all, and just put in an issue to avoid forgetting about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants