Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide (configurable) filters for file tree #30

Open
pmuir opened this issue Jul 10, 2013 · 10 comments
Open

Provide (configurable) filters for file tree #30

pmuir opened this issue Jul 10, 2013 · 10 comments

Comments

@pmuir
Copy link
Contributor

pmuir commented Jul 10, 2013

We need to be able to configure filters for the file tree - in particular for this release we need to be able to show files with a given extension. It probably makes sense to make this configurable (not necessarily exposed to the user).

@LightGuard
Copy link
Member

We're currently filtering quite a few things already. The logic is
currently reversed (don't show files matching _____ instead of only show
files matching ____). Which files do you have in mind?

On Wed, Jul 10, 2013 at 9:20 AM, Pete Muir [email protected] wrote:

We need to be able to configure filters for the file tree - in particular
for this release we need to be able to show files with a given extension.
It probably makes sense to make this configurable (not necessarily exposed
to the user).


Reply to this email directly or view it on GitHubhttps://github.com//issues/30
.

Jason Porter
http://en.gravatar.com/lightguardjp

@wesbos
Copy link
Member

wesbos commented Jul 10, 2013

We could fairly easily add client side filters with checkboxes if you want
to go that route.

On Wednesday, July 10, 2013, Jason Porter wrote:

We're currently filtering quite a few things already. The logic is
currently reversed (don't show files matching _____ instead of only show
files matching ____). Which files do you have in mind?

On Wed, Jul 10, 2013 at 9:20 AM, Pete Muir <[email protected]<javascript:_e({}, 'cvml', '[email protected]');>>
wrote:

We need to be able to configure filters for the file tree - in
particular
for this release we need to be able to show files with a given
extension.
It probably makes sense to make this configurable (not necessarily
exposed
to the user).


Reply to this email directly or view it on GitHub<
https://github.com/awestruct/web-editor/issues/30>
.

Jason Porter
http://en.gravatar.com/lightguardjp


Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-20750652
.

Wes Bos
Web Development & Design
http://www.WesBos.com
http://www.WesBos.com
Skype: wes.bos
Phone: 416 833 3641

@pmuir
Copy link
Contributor Author

pmuir commented Jul 10, 2013

For example, I would like to only show .adoc files - hide all those nasty haml files, dot-files etc.

@pmuir
Copy link
Contributor Author

pmuir commented Jul 10, 2013

And I would like to be able to configure a given filter set as defaults - see #32

@LightGuard
Copy link
Member

client side or server side?

On Wed, Jul 10, 2013 at 9:43 AM, Pete Muir [email protected] wrote:

And I would like to be able to configure a given filter set as defaults -
see #32 #32


Reply to this email directly or view it on GitHubhttps://github.com//issues/30#issuecomment-20751373
.

Jason Porter
http://en.gravatar.com/lightguardjp

@wesbos
Copy link
Member

wesbos commented Jul 15, 2013

Any update on this? If we want to do this client-side I can get started on implementing it.

@LightGuard
Copy link
Member

I can do it server side for now, though in the future it would be good to do this during the settings call (which files to display)

Sent from Mailbox for iPhone

On Mon, Jul 15, 2013 at 7:58 AM, Wes Bos [email protected] wrote:

Any update on this? If we want to do this client-side I can get started on implementing it.

Reply to this email directly or view it on GitHub:
#30 (comment)

@pmuir
Copy link
Contributor Author

pmuir commented Oct 17, 2013

Is this done?

@wesbos
Copy link
Member

wesbos commented Oct 17, 2013

I don't think we ever did this, its set to some default filters.

@LightGuard
Copy link
Member

The back end should support it, but there's nothing in the front end to ask for a filter

Sent from my iPhone

On Oct 17, 2013, at 8:47, Wes Bos [email protected] wrote:

I don't think we ever did this, its set to some default filters.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants