Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(src-js) ApiBlock types are missing the Page property of type number #170

Open
rob3c opened this issue Dec 7, 2023 · 1 comment
Open
Assignees
Labels
javascript Relates to the JavaScript/TypeScript version of TRP

Comments

@rob3c
Copy link

rob3c commented Dec 7, 2023

All ApiBlock types (except ApiQueryBlock and ApiQueryResultBlock) in the javascript source are missing the Page property that's found on all blocks in the JSON response objects. The Python and C# libraries already include it, however.

@athewsey athewsey added the javascript Relates to the JavaScript/TypeScript version of TRP label Jan 18, 2024
@athewsey
Copy link
Contributor

Hi @rob3c, my initial observations on this one (referring to current working version test data sets):

  • On (older from around 2022) table-example-response.json, I see Page on all 84 blocks in the file (including PAGE, LINE, WORD, CELL, MERGED_CELL, TABLE, KEY, and VALUE)
  • Seems similarly universal in test-query-response.json (maybe from around 2023-06), test-multicol-response.json (2021-10ish), test-multicol-response-2.json (2021-10ish), and test-twocol-header-footer-response.json (2021-11ish)
  • BUT I'm not seeing it at all in financial-document-response.json, form1005-response.json, paystub-response.json (all generated around 2023-10 I think), or test-response.json (weirdly, seems to have been updated 2023-05)

Tentative hypothesis that maybe this field stopped getting reported at block level some time perhaps mid 2023? ...Unless you're still seeing it in more recent API results now? Or if @schadem can shed any more light on it.

Definitely agree it looks worth adding to the type model in some capacity, but e.g. maybe if it's disappeared already we can explicitly mark it as such in the JSDoc, and not attach it to block types for features that came out after it went away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Relates to the JavaScript/TypeScript version of TRP
Projects
None yet
Development

No branches or pull requests

2 participants