Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Functions: Cannot specify 'Pinned' value #9

Open
ShaunEdiger opened this issue Jan 29, 2018 · 4 comments
Open

Functions: Cannot specify 'Pinned' value #9

ShaunEdiger opened this issue Jan 29, 2018 · 4 comments

Comments

@ShaunEdiger
Copy link

As the API is currently exposed, lambda functions referenced with gg_group_setup are on-demand by default with no option to set them to pinned. I need a way to specify that a lambda function is long-lived / pinned – see create_function_definition.

I've been able hack in support by overriding GroupCommands._create_function_definition in a subclass.

After subclassing, the relevant config –
"lambda_functions": { "function_name": { "arn": "function_arn", "arn_qualifier": "dev" }
– is updated to look like this –
"lambda_functions": { "function_name": { "arn": "function_arn", "arn_qualifier": "dev", "pinned": false }

Are there plans to expose this functionality? I can package these changes up into a PR if that's helpful.

@brettf
Copy link
Contributor

brettf commented Jul 2, 2018

This was originally published as a gap-fill until CloudFormation support for GG showed up. That being said, I think that would be a great addition.

@ShaunEdiger
Copy link
Author

Of course, and thank you for the hard work on this project. CloudFormation support would be ideal. I'm not in the position to promise a pull request at the moment. My hope is that a contribution would be useful for at least a little while until CloudFormation support arrives.

@brettf
Copy link
Contributor

brettf commented Jul 4, 2018

I just made some other changes for Issue #13 and #10. So my head is back on this project (:bulb:). I will see about adding the ability to flag functions as pinned when defined in the group.

@brettf brettf self-assigned this Jul 4, 2018
@dostiharise
Copy link
Contributor

dostiharise commented Jan 2, 2020

I have added a similar support for Functions/Environment/Variables under Pull Request #23 against Issue #22 .

You could do the same.

I can work on this if you guys still need this Issue to be resolved. Just 👍 this comment and I will know. :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants