Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imaged get deleted when the are referenced by digest and not by tag #44

Open
MoJo2600 opened this issue Nov 8, 2024 · 0 comments · May be fixed by #45
Open

Imaged get deleted when the are referenced by digest and not by tag #44

MoJo2600 opened this issue Nov 8, 2024 · 0 comments · May be fixed by #45

Comments

@MoJo2600
Copy link

MoJo2600 commented Nov 8, 2024

In my setup images get deleted although they are still being referenced in a task definition. I dug a little deeper and it seems like images are not recognized as running, when they are directly referencing an image by digest and not by tag. So if one is using the format repositoryurl/image@sha256:digest it does never match and thus the image will be added to the images to delete list.

I created a change that will check if the task definition is referencing an image via digest and will also add those images to the list to keep. But I'm not sure if this is the best solution and maybe my setup with referencing the image via digest might be an anti pattern somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant