-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for supplemental CSS classes #244
Comments
It occurs to me (and @bugfolder) that we probably ought to provide some documentation for core contributors on how to use supplemental CSS classes in PR's that effect Basis. I could try to write this documentation. But, may wait until I have a chance to discuss at a meeting. |
One thing to clarify may be whether or not to use Here are the first three PR's using the new class. |
Unfortunately, I get |
That's part of a more general question: should we we always strive for the minimum-sized selector necessary (versus giving a hint to CSS readers which DOM element is carrying the selector)? An existing example would be |
Since it specifically states that it's applicable to 1.30 (and later), I'm taking the liberty of publishing it to make it visible to potential reviewers like @izmeez and others. I like it. I'd suggest it belongs at User Guide > Using Backdrop > Themes > Default Theme: Basis—which is right where @stpaultim set it to appear (so agreement on placement). |
Thank you for publishing the draft doc. At the point where it goes:
This can have a heading:
Before this section it may help to have a section,
|
On the docs page
|
We need to add documentation to support backdrop/backdrop-issues#4782
I'm not sure where to put this documentation, so I created a new documation page for Basis here:
https://docs.backdropcms.org/documentation/default-theme-basis
I welcome feedback on the location and content of this page.
This page is currently in draft mode and should not be published until the release of version 1.30.
The text was updated successfully, but these errors were encountered: