Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public holidays should be recognised #887

Open
l0x opened this issue Apr 6, 2023 · 5 comments
Open

Public holidays should be recognised #887

l0x opened this issue Apr 6, 2023 · 5 comments

Comments

@l0x
Copy link

l0x commented Apr 6, 2023

This is a more generic version of the previously addressed issue #594

The timezone should be used to lookup a calendar of public holidays in that region, and it should not recommend deploying on days before public holidays!

@elydpg
Copy link

elydpg commented Dec 25, 2023

Agreed! Also, the work week varies by locale. In my locale, Christmas is a normal workday (as are Sundays) so there's no reason for me not to deploy today 🤷

@elydpg
Copy link

elydpg commented Dec 25, 2023

This issue should really be titled "Localize weekends and holidays"

@wallacetm
Copy link

+1 on this one! If this feature was already developed, it wouldn't stop production today in Brazil!

@baires
Copy link
Owner

baires commented Dec 27, 2024

https://date.nager.at/Api Seems a good option for this

@elydpg
Copy link

elydpg commented Dec 28, 2024

https://date.nager.at/Api

Doesn't seem to localize weekends, though that can be done separately I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants