Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting schema_dir at runtime, overriding YAML contents #15

Open
baltzell opened this issue Mar 7, 2023 · 2 comments
Open

Allow setting schema_dir at runtime, overriding YAML contents #15

baltzell opened this issue Mar 7, 2023 · 2 comments
Assignees

Comments

@baltzell
Copy link
Owner

baltzell commented Mar 7, 2023

A new option --schemaDir can copy in the YAML file locally and modify it in the job, replacing schema_dir (or adding it if it doesn't exist) with the CLI option.

The YAML is the one thing that can be altered by users after workflow generation, if they add the write bit or "rm -f" and remake it, both of which are bad.

Another option is to copy it to a temporary location, but I'm not sure that overhead is worth it and can lead to other complications.

@raffaelladevita
Copy link
Collaborator

I like the idea of the new --shemaDir option because often chefs use multiple yamls that differ only for the schema directory to produce different output types.

I agree that changing the yaml after the workflow is generated should be discouraged and the option of copying the yaml seems indeed a potential source of (other) problems.

@baltzell
Copy link
Owner Author

baltzell commented Mar 8, 2023

We could also read the YAML in the job from the README.json that is generated at submit time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants