Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some automated test for the library #19

Open
jedbrown opened this issue Aug 8, 2017 · 1 comment
Open

Some automated test for the library #19

jedbrown opened this issue Aug 8, 2017 · 1 comment

Comments

@jedbrown
Copy link
Contributor

jedbrown commented Aug 8, 2017

AmgXWrapper has two distribution modes: as source files to be compiled by the client and as a shared library. Bundling the source files is perhaps not too onerous for an application, but wholly inappropriate for another library -- libraries cannot assume that some other part of the application won't also call AmgXWrapper. As far as I can tell, there are no examples or automated tests for the library. It's also rather complicated to determine if things are working correctly upon building the library -- you need to go out into a different directory and configure a different build (probably with the same command-line options) to build the example, then run it and parse the output (which has some terminal noise; e.g., about JSON vs AmgX input file formats). There should at least be a "make test" target that for the library that verifies that the build is working correctly.

@piyueh
Copy link
Member

piyueh commented Aug 9, 2017

Agree. We will create some automatic tests and make both examples use the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants