Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: bsdtar.exe fails to run on windows: libcrypto dll not found #848

Open
peakschris opened this issue May 16, 2024 · 5 comments
Open
Labels
bug Something isn't working untriaged Requires traige

Comments

@peakschris
Copy link

peakschris commented May 16, 2024

What happened?

With rules_js 1.42.1 (and aspect_bazel_lib 2.7.3) on Windows, running js_test targets fails due to a missing crypto DLL:

D:\workspace>bazel test //src/test --verbose_failures
WARNING: Streamed test output requested. All tests will be run locally, without sharding, one at a time
INFO: Analyzed target //src/test:test (0 packages loaded, 0 targets configured).
ERROR: D:/workspace/BUILD.bazel:6:22: Extracting npm package @types/[email protected] failed: (Exit -1073741515): bsdtar.exe failed: error executing NpmPackageExtract command (from target //:.aspect_rules_js/node_modules/@[email protected]/pkg)
  cd /d D:/udu/b/nag22qmp/execroot/_main
external\aspect_bazel_lib~~toolchains~bsd_tar_windows_amd64\libarchive\bin\bsdtar.exe --extract --no-same-owner --no-same-permissions --strip-components 1 --file external/aspect_rules_js~~npm~npm__at_types_node__20.12.12/package.tgz --directory bazel-out/x64_windows-opt/bin/node_modules/.aspect_rules_js/@[email protected]/node_modules/@types/node
# Configuration: d850a7e5673f06961afdd7f68e62a46ae2620e12a4464604ad6d160b42ae6c5f
# Execution platform: @@my_toolchain~//platforms:x64_windows
Target //src/test:test failed to build
INFO: Elapsed time: 1.440s, Critical Path: 0.93s
INFO: 41 processes: 41 internal.
ERROR: Build did NOT complete successfully
//src/test:test    FAILED TO BUILD

Running the exe by double clicking is the easiest way to see what dependency is missing:
image

The issue is that libcrypto-1_1-x64.dll is not found

Version

Development (host) and target OS/architectures:

Output of bazel --version:
7.2.0rc1

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:
rules_js 1.42.1
aspect_bazel_lib 2.7.3

Language(s) and/or frameworks involved:

How to reproduce

No response

Any other information?

No response

@peakschris peakschris added the bug Something isn't working label May 16, 2024
@github-actions github-actions bot added the untriaged Requires traige label May 16, 2024
@peakschris
Copy link
Author

This is the relevant open issue libarchive/libarchive#1925

@jjh42
Copy link

jjh42 commented Jul 26, 2024

Did you find any workaround for this, like installing the dll?

@peakschris
Copy link
Author

peakschris commented Jul 26, 2024

No, I'm still blocked for now on windows.

There has been action fixing a chain of issues, thanks to everyone who has contributed. The current issue is aspect-build/bsdtar-prebuilt#3. So I'm hoping it won't be long.

@jjh42
Copy link

jjh42 commented Jul 26, 2024

This is my hack workaround to use system version of bsdtar (I'm using msys2 on windows). So its no longer hermetic toolchain but seems to work for me.

elefant-ai/rules_js@e98e7d4

@thesayyn
Copy link
Collaborator

thesayyn commented Nov 1, 2024

Related, #968

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged Requires traige
Projects
None yet
Development

No branches or pull requests

3 participants