Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cta_rate_units from the fuel_carbon_tax_detail table #440

Open
dleard opened this issue Apr 5, 2022 · 0 comments
Open

Remove cta_rate_units from the fuel_carbon_tax_detail table #440

dleard opened this issue Apr 5, 2022 · 0 comments

Comments

@dleard
Copy link
Contributor

dleard commented Apr 5, 2022

These rate units actually belong to the data in the carbon_tax_act_fuel_type table. They have already been added there & this card is about maintaining database normalization, since we now have duplicate data between the two tables.

This will require changes to be done in the CIIP repo first before making any changes in the GGIRCS repo. CIIP's get_carbon_tax_data() function will need to derive the cta_rate_units column from the carbon_tax_act_fuel_type table instead of the fuel_carbon_tax_detail table. This will need to be deployed to prod before the change to GGIRCS or the function will break.

Once the change to CIIP has been made we can just drop the cta_rate_units column from the fuel_carbon_tax_detail table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant