-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beancount v3 compatiblity #1860
Comments
I look forward to the day when fava and beancount fully support v3. When it enters a stable state, I will immediately migrate from v2 to v3. Does anyone know the time node? |
Merged #1859 just now so Beancount v3 support is now on the main branch :) I think we're good on the beanquery-front, importing still probably needs more work (no support yet for new-style beangulp importers) |
With #1917 we now also have support for importers inheriting from |
I just released 1.30 (very happy about the fitting version number) with these changes :) I'll leave this issue open for a bit for feedback on this topic. |
Is there a difference how the hooks are called in fava vs plain beangulp? When I call the import script directly, my hooks are receiving 4 values (filename, entries, account and importer), if I use the same script through fava, I only get 2 (filename and entries). |
I'm using the latest Docker image, and it says:
Shouldn't it read Beancount v3 or something? :) |
It seems there is - I didn't change anything compared to v2, so they're still called the "old" way. A PR to fix that would be welcome (I guess we should inspect the hook signature to be compatible with both) - edit: nevermind, AFAICT Fava and beangulp both call hooks with just two arguments, the imported and the existing entries.
We don't provide a Docker image so you'll need to raise this with whomever you got this from. |
I'm getting this when I try to run the fava I just installed, with beancount v3 installed from source.
Here are the versions of what I have:
|
The latest development version of Beancount is currently not compatible with the latest released version of beangulp. You'll need to either install both from source or both from released versions. |
Tracking issue. See #1859 for ongoing work.
A version of Fava that supports both v2 and v3 seems feasible. This would use the
beanquery
package on both version, introducing some changes to which queries work.See also:
The text was updated successfully, but these errors were encountered: