Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(jsruntime): implement own code generator and replace bindgen with it #260

Closed
masnagam opened this issue Aug 10, 2024 · 4 comments · Fixed by #355
Closed

refactor(jsruntime): implement own code generator and replace bindgen with it #260

masnagam opened this issue Aug 10, 2024 · 4 comments · Fixed by #355
Assignees
@masnagam

Comments

@masnagam
Copy link
Member

No description provided.

@masnagam
Copy link
Member Author

we cannot use cxx because it does not support union types.

@masnagam
Copy link
Member Author

masnagam commented Nov 4, 2024 •
edited
Loading

cbindgen seems to be better than bindgen.

normally, it's used for exporting api from rust for applications, but it's can be used for generating header files for the porting layer.

@masnagam masnagam changed the title feat(jsruntime): implement own code generator and replace bindgen with it refactor(jsruntime): implement own code generator and replace bindgen with it Nov 4, 2024
@masnagam
Copy link
Member Author

masnagam commented Nov 5, 2024

cbindgen does not generate forward declarations for pointer types properly.
see mozilla/cbindgen#43.

@masnagam masnagam self-assigned this Nov 6, 2024
@masnagam
Copy link
Member Author

masnagam commented Nov 7, 2024

noticed that many types defined in bridge.hh are used only in jit-generated code.
so, no problem even if we remove those types from bridge.hh.

@masnagam masnagam mentioned this issue Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masnagam masnagam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(jsruntime): bridge bee-browser/bee
1 participant
@masnagam