Add CI

[ben-grande]

Qusal has a lot of checks done by Github Actions. The problem is how to make it reusable (avoid code duplication).

The Github Action reusability is easy, but the problem is the qusal/scripts directory, how to reuse it? If it is not possible, how to keep it in sync? Prohibit changes to it from downstream dotfiles and only allow changes to be made directly to qusal and then copied to dotfiles?

Impacts:

• feat: Allow to exclude dotfiles on pillar data #1

[seven-beep]

You seems very well versed in good practices, so take my comment with a grain of salt,

What is the plus value of making this repository a submodule ? Do you use it as standalone ? It does not seems so ...

I understand that by principle you want to separate your 'dotfiles' from 'qusal' from a theorical perspective but well ...

At this point, 'dotfiles' is not a personal configuration but a needed dependency for 'qusal'.

Why not merging it into qusal ? The benefits would be :

• No more issues about github actions
• less instructions to setup qusal from git

[ben-grande]

You seems very well versed in good practices, so take my comment with a grain of salt,

I try, but not sure, this is my first big project.

What is the plus value of making this repository a submodule ? Do you use it as standalone ? It does not seems so ...

So it can be used outside of Qubes environment without having extra unneeded files involved, as the dotfiles are not Qubes specific, although they have specific Qubes files.

I use it as a standalone when I install my dotfiles to any machine, but I guess that if problems arise of not having CI, I may sacrifice it for a way to fix the bigger problem.

I understand that by principle you want to separate your 'dotfiles' from 'qusal' from a theorical perspective but well ...

The dotfiles were actually a directory just like any other formula, but you can't see that through commit as this was before I had a clean history and the first commit already has dotfiles as a submodule.

At this point, 'dotfiles' is not a personal configuration but a needed dependency for 'qusal'.

I try to not make my dotfiles a personal configuration, allowing for user configuration, but I understand your point. It is true that at this stage, before implementing the dotfiles' pillars, it is a dependency, that I'm hoping it won't be anymore.

Why not merging it into qusal ? The benefits would be :

• No more issues about github actions
• less instructions to setup qusal from git

That is true, submodules really lengthen up the instructions. I will think about that, I will study more in the meantime.

When I moved dotfiles to its own submodule, I did not think through of these consequences, I guess only time can teach.

[seven-beep]

use it as a standalone when I install my dotfiles to any machine, but I guess that if problems arise of not having CI, I may sacrifice it for a way to fix the bigger problem.

This is very a solid reason, indeed.

Looking at the community discussions, peoples seem to workaround this by using a docker image to embed the necessary files or to fetch the raw files rather than using their path.