Homebridge 2.0

[spaceg00se-r]

Hi

Will your plugin be compatible with Homebridge 2.0 (https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0)? Do you plan to make the changes to the plugin and/or the package.json file as described in the link above?

[benzman81]

Until now, I didn't even know about v2.0. Since I am a bit busy right now, I have no time left to check this. Feel free to contribute via pull request, then I will have a look at it.

[jsiegenthaler]

Making it v2 compatible is pretty easy, I'll have a go for you

[spaceg00se-r]

Nice @jsiegenthaler!

[jsiegenthaler]

@benzman81

I made changes to work with Homebridge v2 as follows:

0.1.19-beta.1

From jsiegenthaler:
Updated package.json to show compatibility with Homebridge v2
Tested on Homebridge v2 with a motion sensor, all OK
Updated dependencies:
"http-auth": "^4.2.0",
"node-persist": "^2.1.0",
"request": "^2.88.2",
"selfsigned": "^2.4.1"
NOTE: a newer version of node-persist exists but all storage commands are async, requiring more code changes

I created Pull Request #198 for these changes
I tested the changes with a motion sensor on Homebridge v2, all OK.
Note that node-persist cannot be updated beyond v2 without doing code changes, and I decided I'd leave the code changes for someone else.

[spaceg00se-r]

Hey @jsiegenthaler. Great work! Thank you so much!

Since it seems you have a 2.0 testbed... could you do me a giant favour? Could you please have a look at the following plugins to see if they are already compatible for the 2.0 update?

https://github.com/rasod/homebridge-dummy-garage#readme
https://github.com/alexryd/homebridge-shelly#readme
https://github.com/alexryd/homebridge-shelly-ng#readme

[jsiegenthaler]

Hi @spaceg00se-r
I do have homebridge-shelly installed so I guess could install and test that one on my dev environment. (But really the plugin developper should be doing this work.) I don't use the other two and am not familiar with them at all sso I don't want to touch them.
I also have 2 of my own plugins that I'm currently working on and they have higher priority for me.... I only did the webhooks plugin as I've contributed to that project in the past and was partly familiar with the plugin.

[spaceg00se-r]

@jsiegenthaler Thanks for the reply. Since the two Shelly Plugins are not really actively maintained anymore, I would appreciate it a lot if you could check homebridge-shelly. I'll then try to find someone that could have a look at the other two :-).

[jsiegenthaler]

@spaceg00se-r if the Shelly plugin owners have abandoned the plugin, then no changes can be made, as they would never read my PR and would never implement any changes...

[spaceg00se-r]

@jsiegenthaler i understand. Sad to hear that. Would the plugin be able to run on HB 2.0 as is? I understand you have a test env and are using the plugin, right?

[jsiegenthaler]

You can try it yourself. Just update Homebridge to the 2.0 beta version and observe what happens. View your logs. Then you will know. That's all that I'm doing. You can always revert Homebridge back to the public release without any issue.