Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jQuery to package.json dependencies #539

Open
lawlesscreation opened this issue Mar 25, 2019 · 1 comment
Open

Add jQuery to package.json dependencies #539

lawlesscreation opened this issue Mar 25, 2019 · 1 comment

Comments

@lawlesscreation
Copy link

Hi,

If I understand package.json dependencies correctly, as jQuery is required for Spectrum then it should be listed as a dependency?

I'm happy to raise a PR for this. Is there any particular version of jQuery required?

@ephemere000
Copy link

I agree with lawlesscreation. I installed the package in my native JS application only to find out it's jQuery dependency. :(

I had read the Devtools section of http://bgrins.github.io/spectrum/ and it said specifically: Then I pulled the jQuery dependency out of a branch and I submitted a patch to the WebKit project. Moreover package.json does not contain the dependency, JQuery is therefore not on the GitHub dependencies section.

I assumed wrongly that JQuery was removed since it's integration with the WebKit. I guess it was just a separate specific branch.

Finally, I saw on the http://bgrins.github.io/spectrum/ page the header: "The No Hassle JQuery Colorpicker". We obviously don't often look at the stylized small header of a web page, we mainly focus on the big headers and main content. I discovered it with the search in page tool!

It looks like a great and useful tool. If ever that vanilla JS branch were available, I would give it a shot! Most programmers do not use jQuery on any new project since HTML 5.
:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants