Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Keywords - language from corpus #961

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented Mar 29, 2023

Description of changes
  • Make YAKE and RAKE modules to use ISO language
  • Use language from the corpus for the Keyword Extraction widget
  • Fix sorting in LanguageModel and add tests
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the language-keyword branch 6 times, most recently from 1912e20 to 206171a Compare February 23, 2024 13:09
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Merging #961 (153e06f) into master (7456311) will increase coverage by 0.07%.
The diff coverage is 97.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
+ Coverage   82.27%   82.34%   +0.07%     
==========================================
  Files          93       93              
  Lines       12448    12474      +26     
  Branches     1699     1705       +6     
==========================================
+ Hits        10241    10272      +31     
+ Misses       1895     1892       -3     
+ Partials      312      310       -2     

@PrimozGodec PrimozGodec force-pushed the language-keyword branch 2 times, most recently from f32ff03 to 36b417b Compare February 23, 2024 13:27
@PrimozGodec PrimozGodec marked this pull request as ready for review February 23, 2024 13:29
@PrimozGodec PrimozGodec requested a review from VesnaT February 23, 2024 13:36
@PrimozGodec PrimozGodec assigned PrimozGodec and VesnaT and unassigned PrimozGodec Feb 23, 2024
Copy link
Contributor

@VesnaT VesnaT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rake language order seem strange. Consequently, in saved workflows the selected language is not the same as in previous version.
image

@VesnaT VesnaT merged commit 6aad2ad into biolab:master Apr 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants