Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Corpus: Store titles in corpus to match between Corpus Viewer even when subsampled #490

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

PrimozGodec
Copy link
Collaborator

Issue

Fixes #482

Description of changes
  • Now titles are stored in the corpus and subsampled together with the corpus.
  • Functionality to set tile is moved from widget to corpus.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #490 into master will increase coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage   62.02%   62.17%   +0.15%     
==========================================
  Files          59       59              
  Lines        6199     6224      +25     
  Branches      809      812       +3     
==========================================
+ Hits         3845     3870      +25     
  Misses       2218     2218              
  Partials      136      136

@PrimozGodec PrimozGodec changed the title corpus: Store titles to be same in subsample. [ENH] Corpus: Store titles in corpus to match between Corpus Viewer even when subsampled Dec 27, 2019
@ajdapretnar ajdapretnar merged commit ca0e891 into biolab:master Jan 13, 2020
@PrimozGodec PrimozGodec deleted the corpus-title-unique branch March 29, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corpus Viewer: add numbers to titles when values not unique
3 participants