Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Word Enrichment - fix PyQt6 incompatibility and sort imports #901

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

PrimozGodec
Copy link
Collaborator

Issue

Word Enrichment is not compatible with PyQt6.

Description of changes

Fix PyQt6 compatibility. Note that other incompatibilities are already addressed in other opened PRs.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec
Copy link
Collaborator Author

Test are fixed in #900
Rebase when merged

@codecov-commenter
Copy link

Codecov Report

Merging #901 (83c7087) into master (339ad59) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
+ Coverage   76.94%   76.96%   +0.01%     
==========================================
  Files          86       86              
  Lines       12151    12151              
  Branches     1905     1905              
==========================================
+ Hits         9350     9352       +2     
+ Misses       2485     2484       -1     
+ Partials      316      315       -1     

@PrimozGodec
Copy link
Collaborator Author

/rebase

@PrimozGodec PrimozGodec merged commit 2bb750f into biolab:master Sep 2, 2022
@PrimozGodec PrimozGodec deleted the pyqt6-compatiblity branch September 2, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants