Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat Map: don't show bow attributes if flag hidden=True #5306

Closed
3 tasks
ajdapretnar opened this issue Mar 4, 2021 · 5 comments · Fixed by #6000
Closed
3 tasks

Heat Map: don't show bow attributes if flag hidden=True #5306

ajdapretnar opened this issue Mar 4, 2021 · 5 comments · Fixed by #6000
Labels

Comments

@ajdapretnar
Copy link
Contributor

ajdapretnar commented Mar 4, 2021

  • What's your use case?

Some visualization widgets will ignore bow attributes if they have a hidden=True flag (in attributes of attributes). Heat Map would benefit from the same setup: ignoring bow attributes (and showing just sentiment, topics, etc.).

  • What's your proposed solution?

Add the same option as Box Plot has it for hiding bow attributes.

  • Are there any alternative solutions?

Keep it as is.

@ajdapretnar
Copy link
Contributor Author

What do you think @PrimozGodec?

@PrimozGodec
Copy link
Contributor

Hmm, it is a difficult one. On one side it would be nice to be consistent and remove hidden attributes. On the other side, what if someone wants to see embeddings on the heatmap. Then she/he would need to go through each attribute in the edit domain and change hidden attribute to False.

Another solution would be to remove hidden attributes from the heatmap and add a checkbox to the embedding widgets same as in the Bag of words widget.

I am actually more for this second option. This way we give the user the option to hide some attributes and still he can check embeddings with the heatmap.

@ajdapretnar
Copy link
Contributor Author

Right, I forgot embeddings are also hidden. Yes, this would make sense - adding a checkbox to Doc Emb would make the most sense. And of course hiding hidden attributes in Heat Map.

@ajdapretnar
Copy link
Contributor Author

I think this was the proposed solution:

  • Add a checkbox to Document Embedding with the option to hide/unhide bow attributes (see BoW for example).
  • Hide "hidden" attributes in Heat Map (as in Box Plot).

@ajdapretnar
Copy link
Contributor Author

Partially fixed in biolab/orange3-text#852.
The rest is fixed in #6000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants