Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library breaks with float feeRate #87

Open
Distance71 opened this issue Jan 16, 2024 · 0 comments
Open

Library breaks with float feeRate #87

Distance71 opened this issue Jan 16, 2024 · 0 comments

Comments

@Distance71
Copy link

Float fee rates are not something uncommon. Something like 0.1, 100.2, ...

On the other hand, If We check uintOrNaN, float fee rates are not handled by the library

As much as I could see, it can be easily fixed by removing that line on utils uintOrNaN, setting Math.round() on both accumulative and blackjack, and finalize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Distance71