Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put prettify in separate package? #16

Open
afbjorklund opened this issue Aug 28, 2023 · 1 comment · May be fixed by #17
Open

Put prettify in separate package? #16

afbjorklund opened this issue Aug 28, 2023 · 1 comment · May be fixed by #17

Comments

@afbjorklund
Copy link

afbjorklund commented Aug 28, 2023 •
edited
Loading

Hi, thank you for this interesting tool!

Would it be possible to put the Prettify function into a separate package for use as a library?

Now when you import gotestdox, you also get all the command dependencies like "color"...

Was testing it with go-test-report

--- a/go.mod
+++ b/go.mod
@@ -3,6 +3,7 @@ module github.com/vakenbolt/go-test-report
 go 1.17
 
 require (
+       github.com/bitfield/gotestdox v0.2.2
        github.com/spf13/cobra v1.7.0
        github.com/stretchr/testify v1.6.1
        golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
@@ -11,7 +12,12 @@ require (
 
 require (
        github.com/davecgh/go-spew v1.1.1 // indirect
+       github.com/fatih/color v1.15.0 // indirect
        github.com/inconshreveable/mousetrap v1.1.0 // indirect
+       github.com/mattn/go-colorable v0.1.13 // indirect
+       github.com/mattn/go-isatty v0.0.19 // indirect
        github.com/pmezard/go-difflib v1.0.0 // indirect
        github.com/spf13/pflag v1.0.5 // indirect
+       golang.org/x/sys v0.10.0 // indirect
+       golang.org/x/text v0.11.0 // indirect
 )
@afbjorklund
Copy link
Author

https://github.com/afbjorklund/go-test-report/tree/gotestdox adds a --testdox flag (and a DisplayName)

@afbjorklund afbjorklund linked a pull request Aug 28, 2023 that will close this issue
Draft
@afbjorklund afbjorklund mentioned this issue Sep 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move non-command functions to a package afbjorklund/gotestdox
1 participant
@afbjorklund