Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect publicBaseUrl reference from https://github.com/bitnami/charts/pull/28543 #31131

Open
busyboy77 opened this issue Dec 20, 2024 · 1 comment
Assignees
Labels
kibana tech-issues The user has a technical issue about an application triage Triage is needed

Comments

@busyboy77
Copy link

Name and Version

bitnami/kibana 11.4.0

What architecture are you using?

amd64

What steps will reproduce the bug?

#28543 has been implemented with an incorrect reference to the basePath parameter is now required to be appended exactly after the publicBasePath parameter

 configuration:
     server:
       basePath: /ef-kibana
       rewriteBasePath: true
       publicBaseUrl: "https://myfqdn.com/ef-kibana"

but the automatic placement template in templates/configmap.yaml it is referenced incorrectly as below

data:
  kibana.yml: |
    pid.file: /opt/bitnami/kibana/tmp/kibana.pid
    server.host: {{ .Values.configuration.server.host | quote }}
    server.port: {{ .Values.containerPorts.http }}
    elasticsearch.hosts: [{{ include "kibana.elasticsearch.url" . }}]
    {{- if .Values.configuration.server.basePath }}
    server.basePath: {{ .Values.configuration.server.basePath | quote }}
    {{- end }}
    {{- if or .Values.configuration.server.publicBaseUrl .Values.ingress.enabled }}
    server.publicBaseUrl: {{ default .Values.ingress.hostname .Values.configuration.server.publicBaseUrl }}
    {{- end }}
    server.rewriteBasePath: {{ .Values.configuration.server.rewriteBasePath }}

Details

When a custom configuration is used for kibana to be served behind ingress ( ingress-nginx in our case ), the newer version of kibana expects that the basePath should be automatically appended after the .Values.ingress.hostname or the value of .Values.configuration.server.publicBaseUrl which if NOT Set, will be set to only the .Values.ingress.hostname, resulting in error of bother basePath and publicBaseUrl are incorrect

Ideally it should

    {{- if  or .Values.ingress.tls  .Values.ingress.extraTls  }}
    {{- $scheme := "https://"  }}
    {{- else }}
    {{- $scheme := "http://" }}
    {{- end }} 
    {{- if  and ( not  .Values.configuration.server.publicBaseUrl)   .Values.ingress.enabled }}
    server.publicBaseUrl:  {{ $scheme  }}{{ .Values.ingress.hostname }}/{{ .Values.configuration.server.basePath }}
    {{- else }}
    server.publicBaseUrl:  {{ $scheme  }}{{ .Values.configuration.server.publicBaseUrl  }}/{{ .Values.configuration.server.basePath }}
    {{- end }}

Are you using any custom parameters or values?

#28543

What is the expected behavior?

#28543

What do you see instead?

#28543

Additional information

#28543

@busyboy77 busyboy77 added the tech-issues The user has a technical issue about an application label Dec 20, 2024
@github-actions github-actions bot added the triage Triage is needed label Dec 20, 2024
@carrodher
Copy link
Member

Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kibana tech-issues The user has a technical issue about an application triage Triage is needed
Projects
None yet
Development

No branches or pull requests

3 participants