Interpret field_or_op before sub_expression #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acerbusace
requested review from
myronmarston and
BrianSigafoos-SQ
as code owners
myronmarston
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
💯 Looking good! To get a green build I think you'll need to rebase once #23 is merged.
elasticgraph-graphql/lib/elastic_graph/graphql/filtering/filter_node_interpreter.rb
Show resolved
Hide resolved
| @@ -103,6 +103,8 @@ def filters_on_sub_fields?(expression) | |||
| end | |||
|
|
|||
| def process_not_expression(bool_node, expression, field_path) | |||
| return if expression.nil? || expression == {} | |||
There was a problem hiding this comment.
According to the RBS signature, expression cannot be nil. Before now that was true but with your refactoring it can now be nil.
Can you update the RBS signatures for these methods to account for the new possible values?
acerbusace
force-pushed
the
block/alexp/identifyNodeTypeChange
branch
2 times, most recently
from
9289923 to
03ece85
Compare
acerbusace
force-pushed
the
block/alexp/identifyNodeTypeChange
branch
from
03ece85 to
5dc50df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Interpret field_or_op before sub_expression. More details here.