Deal with rackup 2.2 release. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rackup 2.2 no longer depends on `webrick`, and our usage of `rackup` fails if we don't add a dependency on `webrick`. For details on the `rackup` change, see: rack/rackup#23 Note that the `rackup` maintainers recommend using `falcon` or `puma` instead of `webrick`. However, `falcon` and `puma` are heavier weight. `falcon` has lots of runtime dependencies and `puma` depends on `nio4r` which has native code. As a result, it's more likely to hit installation issues for ElasticGraph users than `webrick`. So for now we are sticking with `webrick` but I'm open to changing this in the future.
myronmarston
force-pushed
the
myron/deal-with-rackup
branch
from
966e391 to
4fadb29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rackup 2.2 no longer depends on
webrick, and our usage ofrackupfails if we don't add a dependency onwebrick. For details on therackupchange, see:rack/rackup#23
Note that the
rackupmaintainers recommend usingfalconorpumainstead ofwebrick. However,falconandpumaare heavier weight.falconhas lots of runtime dependencies andpumadepends onnio4rwhich has native code. As a result, it's more likely to hit installation issues for ElasticGraph users thanwebrick. So for now we are sticking withwebrickbut I'm open to changing this in the future.