-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function names lost with 1.6 #159
Comments
That test passes with 1.6.0-alpha05 but fails in alpha06. The alpha06 build was the first to contain that change in the description so it does seem more likely that that is the issue: https://android.googlesource.com/platform/frameworks/support/+log/9ce75ea1baa2af10dda8f787f69c40c6654bcac1..91bb8c1f81dcb031bda00fcd8e55f1e890b56f06/compose/ui |
It looks like you can access the composer via the
I wonder if this global val could also replace the reflection done in |
Discussed a bit offline. Radiography doesn't directly insert itself into the composition, so it's not easy to get the "current" composer in the general case. However, for this specific use case, inside a test, Radiography could probably provide a helper that would set things up correctly. |
How could we make this work beyond tests? Can we grab the component from the compose view? Also, @zach-klippenstein could this use case maybe be considered by the Compose team :) ? Is it really unreasonable to need access to an API that allows us to describe a compose hierarchy and export that somewhere? |
Hi @zach-klippenstein, thanks for this great library! I am also running into this issue of missing names with Is there any update or known workaround? |
Hi @zach-klippenstein |
When using Compose 1.6.0, the function names are no longer available. This is reproduced in the
nestedLayouts
test which fails:It looks to be related to this change in Compose: https://android-review.googlesource.com/c/platform/frameworks/support/+/2741462. However, it doesn't seem as simple as calling
composer.collectParameterInformation()
.The text was updated successfully, but these errors were encountered: