-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including Readme on the extension/theme page #19
Comments
The import already fetches the readme info in, so adding would be pretty easy. The only reason I didn't output it is the problem of versions, since theoretically each version or release has a different version of the README.md file, so knowing which one to use as the canonical one on the extensions page can be a bit of a problem. We could just show whatever the master version of README.md is, as long as that wouldn't cause any issues for people. |
I would use the readme of the latest version because that will be the version the user would pull in. |
Wouldn't it be better if the description supported markdown so that we could write better descriptions that way? Perhaps even a tagline field to use in listings and only show the description on the individual screen. The readme is more "how to use" rather than "why to use". |
But "how to use" is the important thing, isn't it? Otherwise we can go crazy and support markdown but provide a button to automatticly import the readme. Or the user can chose if he want write an extra description for the store or want to display the readme from the latest stable version. |
"How to use" is important once it is installed. "Why" is important when selecting/discovering extensions. Once it is installed you have access to the readme from the backend (where you actually need to know "how").
I like this idea, seems like the best of both worlds :) |
Great! Let's stick with that! :) |
I beg to differ. The current 1 or 2-liner "why" is good as an intro shown in the search result list, but insufficient for the main page of an extension. Right now I know that I'll have to leave Bolt's extensions page each time and check the dev's repository to make sure that the extension does what I want in the way that I expect... by checking the readme. Besides, a good readme should answer both the "why" and "how".
Install first ask later? Sounds like a bad idea to me.
Pull the readme only, there's less chances of outdated/mismatching descriptions. |
@kehugter The current solution isn't enough, we agree about that, but I really think that "why" and "how" should be two different things here. Rendering the readme on the extensions site would be good, but I think there should also be room for a separate text that explains the usecase before diving into the readme. Perhaps having two tabs, one for description and one for the readme on each detail page would suffice? That way we could just show the readme if it hasn't got a description, and it would be up to the extension author to decide. |
On boltthemes I just included both because it can't hurt. |
@SahAssar what about implementing a simple parser and providing a template for the readme? I think most devs would find it more convenient and natural than having to keep the readme and Is also convenient for the users: you know where to find the information you need in any bolt extension/theme. If they find an error, a patch can be committed, unlike in Grav implemented this kind of approach nicely for extensions and themes. They fetch basic information from different files in the repo as described in the docs. A structured file ( |
@kehugter That sounds like something that would be great to have in the composer.json since we already define locations for extension icons and screenshots there in the extras section, how about something like this: "extra": {
"bolt-screenshots": [
"screenshots/listing.jpg",
"screenshots/home.jpg"
],
"bolt-assets": "assets",
"bolt-icon": "assets/icon.png",
"readme": "readme.md",
"description": "description.md"
} |
Looks good to me but don't take my word for it, I'm a newcomer at bolt. Some theoretical issues/improvements:
|
Exactly why your input is very useful… we're too used to looking at the same thing! 👍 |
As long as we prefix everything with What I think: Adding more meta is always good but there is no need to define the readme file. Github knows what the readme file is (readme.md, README.md, Readme.md, etc ...), and you can ask Github for that via an API. I also think there is no need to define a description or summary of the package inside the package itself. The extension store is a good place to hold that data. |
I'm with you @PhillippOhlandt … adding more configuration to the JSON file will just mean that nobody does it. The GitHub API sounds like the way to go for me. |
@kehugter: Looks to me like extra can be mostly anything that is meant to be consumed by scripts:
https://getcomposer.org/doc/04-schema.md#extra @PhillippOhlandt didn't you have a problem with getting the right readme file when working on bolthem.es? Also, the point of having it in the package is that it can be versioned and there can be PR's/whatever against it. |
@SahAssar Nope, not with the github api:
I don't think a two sentences summary has to be versioned and maintained by everyone. |
Perfect, agree that it can be removed from the config.
You need a good excerpt for the search results. I wouldn't make it optional.
Some thoughts about that
If the description consists only of one or 2 sentences, could it be just written inside |
If you change it in your repo, you have to click the update button in the extension store anyway. |
You always have the description from the package on the extension store. I wouldn't use the readme as excerpt because it usually starts with the package name (and duplication sucks) |
Can't extensions be hooked?
Agree, me neither. |
Not yet. We are working on that. |
Hey,
most extensions/themes have just one or two sentences as description but a good Readme with all instructions you need.
Maybe we can include it on the extension/theme page so a user can stay on that page and don't have to move to github?
The text was updated successfully, but these errors were encountered: