Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checked in binaries for bflb_iot_tool, bflb_mcu_tool, genromfs, and openocd #2

Open
robertlipe opened this issue Oct 15, 2022 · 2 comments

Comments

@robertlipe
Copy link

https://github.com/bouffalolab/bl808_linux/tree/main/bl_mcu_sdk_bl808/tools/bflb_flash_tool

has binaries checked in for . This is clearly a mistake as it'll never work on ChromeOS, Raspberry Pi, MacOS, self-hosting, or lots of other environments used by the kinds of people working with this kind of code.

PLEASE check in the source, not the binaries.

JLink has similar issues, but that might not be totally up to you. You should at least link out to the Segger page so people can download the "right" JLink.

Please. Just look in the tree for anything with dll, exe, or similar platform-specific artificacts. This bugreport applies to all of them.

bl_mcu_sdk_bl808
is another checked in binary. Source, pelase.

Also, the capitalization inside https://github.com/bouffalolab/bl808_linux/tree/main/bl_mcu_sdk_bl808/drivers/bl808_driver/risc-v is weird. Common convention is to not use upper case in filenames.

@gamelaster
Copy link
Contributor

Hey @robertlipe

https://github.com/bouffalolab/bl808_linux/tree/main/bl_mcu_sdk_bl808/tools/bflb_flash_tool

You can find sources here: https://pypi.org/project/bflb-mcu-tool/

csi_dsp blob

This is work of T-Head, and probably there is some NDA under it, so they can't release the source code.

@YafeiJin
Copy link
Contributor

@robertlipe bflb_flash_tool is removed. Thanks.

alexhorner pushed a commit to alexhorner/bl808_linux that referenced this issue Jan 26, 2023
Replace merge script @BBBSnowball 's script, but modified to skip rootfs and size checks for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants