Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to customize the URLs of Web fonts written in CSS #2413

Open
masa-ent opened this issue Nov 18, 2020 · 1 comment
Open

Add option to customize the URLs of Web fonts written in CSS #2413

masa-ent opened this issue Nov 18, 2020 · 1 comment

Comments

@masa-ent
Copy link

Describe the solution you'd like
I would like to ask for a refurbishment so that I can change the URLs of Web fonts using BoxUIElements options (such as staticHost)

https://github.com/box/box-ui-elements/blob/e460bf23a16776a367e4cbb161568d72abc541dd/src/elements/common/fonts.scss

Describe alternatives you've considered
I think you can use techniques such as CSS custom properties, for example.

https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties

Additional context
Since the URLs of Web fonts is written in CSS in the form of hardcoding, the BoxUIElements option is not effective, and I need to change the URL directly in CSS to change the URLs.

However, since this method requires downloading and saving CSS locally and changing the URLs in specified areas, we are concerned that this may cause problems when upgrading BoxUIElements in the future, such as the need for more time and effort, or the failure to change the URLs.

@mxiao6
Copy link
Contributor

mxiao6 commented Nov 25, 2020

Hi, I've filed this feature request in our internal system. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants