Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

approve pull + logout == failure #43

Open
braddr opened this issue Jan 5, 2015 · 0 comments
Open

approve pull + logout == failure #43

braddr opened this issue Jan 5, 2015 · 0 comments

Comments

@braddr
Copy link
Owner

braddr commented Jan 5, 2015

Logging out tosses away the github access token. In the future, when conditions are met and an attempt to perform the merge happens, the check to make sure the user is still authorized to merge fails. If that step was omitted the merge itself would also fail.

Another failure mode that can occur is if the user is still logged in to the a-t, thus we still have an access token, but it's been revoked on github.

None of these errors are surfaced to the ui in any way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant