We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example of the bug:
error[E001]: expected `]` or `,`, found integer literal ┌─ test.ry:9:5 │ 7 │ fun main() { 8 │ let a = [1, 2 │ ╭─────────────────' 9 │ │ 3] │ │ ^ found integer literal │ ╰' expected `]` or `,` 10 │ } ^^ mismatched outer paddings
It's happening when i try to emit diagnostics with Config::after_label_lines set to 1.
Config::after_label_lines
Why does it happen? The bug appears to happen here and here.
Maybe you should take config.after_label_lines into account when calculating outer padding?
config.after_label_lines
- outer_padding = std::cmp::max(outer_padding, count_digits(end_line_number)); + outer_padding = std::cmp::max(outer_padding, count_digits(end_line_number + self.config.after_label_lines));
- outer_padding = std::cmp::max(outer_padding, count_digits(line_number)); + outer_padding = std::cmp::max(outer_padding, count_digits(line_number) + self.config.end_context_lines);
And also, i don't quite get why do we need to use start_line_number here:
start_line_number
outer_padding = std::cmp::max(outer_padding, count_digits(start_line_number));
I don't know much about the source code, but I hope that someone will make a pull request and fix this for both single and multi line labels.
Note
Correct me, if i misinterpreted something!
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Bug description
Example of the bug:
It's happening when i try to emit diagnostics with
Config::after_label_lines
set to 1.Why does it happen? The bug appears to happen here and here.
Maybe you should take
config.after_label_lines
into account when calculating outer padding?And also, i don't quite get why do we need to use
start_line_number
here:I don't know much about the source code, but I hope that someone will make a pull request and fix this for both single and multi line labels.
Note
Correct me, if i misinterpreted something!
The text was updated successfully, but these errors were encountered: