Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt list before filling in credntials if multiple credentials exist for a domain #360

Open
pjhfggij opened this issue Nov 26, 2024 · 4 comments

Comments

@pjhfggij
Copy link

pjhfggij commented Nov 26, 2024

General information

  • Operating system + version: archlinux (rolling distro)
  • Browser + version: librewolf (Mozilla Firefox 132.0.2-1)
  • Information about the host app:
    • How did you install it? package manager
    • If installed an official release, put a version ($ browserpass --version): DEBU[2024-11-26T22:49:29Z] Starting browserpass host app v3.1.0
    • If built from sources, put a commit id ($ git describe --always):
  • Information about the browser extension:
    • How did you install it? package manager
    • Browserpass extension version as reported by your browser: 3.8.0

Exact steps to reproduce the problem

  1. open a webpage login screen to fill in credentials on a domain with multiple credentials

  2. press shortcut to fill in credentials

  3. credentials get filled in with the last used credentials

What should happen?

I would prefer browserpass extension to prompt a list showing that multiple credentials are available and let user explicitely choose a credentials

Perhaps automatically highlitght the last used credentials to make it easy to choose them

What happened instead?

form was filled in with last used credentials

@maximbaz
Copy link
Member

Hello, I think what you are looking for is the other shortcut we have, which opens the popup 😊 There you see all your multiple credentials, and the last used one is highlighted and ready to be filled in with Enter keypress.

@pjhfggij
Copy link
Author

pjhfggij commented Nov 27, 2024

thanks, yeah I've missed ctrl shift l, maybe that's enough although on most of the websites I just go straight for ctrl shift f to fill in the single credential and only occasionally have to go through multiple credentials, when that happens though I think it would be nice if extension hinted you in some way "is this definitely the credential you wanted to use?"

@maximbaz
Copy link
Member

Ctrl Shift F was primarily built for speed, for cases when you are 100% sure the last login is the correct one - for example for login forms where you first enter email, then submit form, then another form shows up asking for password, and since you just submitted email, you know the password is most definitely in the latest entry - asking for a confirmation would somehow be counter-productive to this idea.

I get that you are looking for a combination of the two, a shortcut that behaves like Ctrl Shift F if there is one credential for the website and Ctrl Shift L if there are more than one, I just don't know it the additional benefits warrant us creating yet another shortcut 🤔

@pjhfggij
Copy link
Author

pjhfggij commented Nov 27, 2024

It would be good to hear from others if they think this type of feature would be useful. I expected people with many credentials to come across this a lot. However, if that was the case more than creating a new shortcut I'd rather add an optional behaviour to old shortcut ctrl shift f to do what ctrl shift l is doing only if multiple credentials are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants