Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entities added after trailing entities deleted #10

Open
brunopostle opened this issue Feb 29, 2024 · 0 comments
Open

Entities added after trailing entities deleted #10

brunopostle opened this issue Feb 29, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@brunopostle
Copy link
Owner

ifcmerge relies on the Native IFC principle that no application will reuse the IDs of deleted elements. However there is a theoretical possibility of failure in this situation:

  1. Application deletes some entities, one or more of them are the 'last' entity with the highest step-ID in the file.
  2. File is saved to disk and opened again by the same or another application.
  3. The new application adds new entities with ID values that have previously been used.

ifcmerge will typically refuse to merge such a file as the class of the ID will likely have changed. This is a robust failure mode, and avoids corruption.

It should be possible for ifcmerge to detect this situation and simply renumber the offending IFC file such that there is no clash before merging.

@brunopostle brunopostle added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant