Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit calculated x-amz-content-sha256 #37

Open
kdiogenes opened this issue Nov 20, 2018 · 1 comment
Open

Permit calculated x-amz-content-sha256 #37

kdiogenes opened this issue Nov 20, 2018 · 1 comment

Comments

@kdiogenes
Copy link

First, thanks for the lib, great work!

I'm using it to sign a multipart upload direct to S3, so the payload never hit my server. I'm calculating it in JavaScript and send it to my server to generate the authorization header.

I was thinking in augment AWSAuth.Utils.build_canonical_request to also check for :hashed in the hashed_payload, in this case, the function uses the hashed payload in the header, what do you think? Can I make a PR?

Best regards!

@kdiogenes
Copy link
Author

I already opened a PR with a possible solution: #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant