Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch with opt_einsum on FLOPs counting #29

Open
mofeing opened this issue Sep 13, 2023 · 0 comments
Open

Mismatch with opt_einsum on FLOPs counting #29

mofeing opened this issue Sep 13, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers question Further information is requested

Comments

@mofeing
Copy link
Member

mofeing commented Sep 13, 2023

I'm not sure why there is this mismatch but I've found the number of FLOPs reported by EinExprs is approximately half of what opt_einsum reports.

I believe that it might be because we are only counting floating-point multiplications, and not sums.

If that is the case, should we really consider counting sums? Current implementations use fmad instructions (i.e. Fused Multiply And Add) which fuse multiplication and addition in only one instruction.

@mofeing mofeing added bug Something isn't working good first issue Good for newcomers question Further information is requested labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant