Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-rvv-env.sh script issues #308

Open
effrey-liu opened this issue May 21, 2024 · 0 comments
Open

build-rvv-env.sh script issues #308

effrey-liu opened this issue May 21, 2024 · 0 comments

Comments

@effrey-liu
Copy link
Contributor

effrey-liu commented May 21, 2024

The build-rvv-env.sh script In buddy-mlir/thirdparty directory has some problems.
First of all, in riscv-gnu-toolchain repo, there is no more rvv-next branch, which should be deleted.
Secondly, when we pull from large git repos, it alaways happens pull failure and takes a lot of time in pull process. For user-friendly reasons, I think it's better to run git clone or git submodule update commands in "while true" block. Like below:

#!/bin/bash
while true; do
    git submodule update --init --recursive
    if [ $? -eq 0 ]; then
        echo "Submodule update completed successfully."
        break
    else
        echo "Submodule update failed. Retrying in 5 seconds..."
        sleep 5
    fi
done

Thirdly, in "Build cross MLIR" and "Build cross Buddy-MLIR" process, leaving out the cd .. command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant