Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core.matrix support #1

Open
mikera opened this issue Sep 18, 2014 · 1 comment
Open

Core.matrix support #1

mikera opened this issue Sep 18, 2014 · 1 comment

Comments

@mikera
Copy link

mikera commented Sep 18, 2014

Hi there, looks like a really promising library!

Have you consider implementing the algorithms in terms of core.matrix (https://github.com/mikera/core.matrix)?

This would give a few advantages:

  • Able to use different matrix / vector implementations
  • Better performance in many cases
  • Integration with other libraries tools e.g. Incanter which uses core.matrix
@bugra
Copy link
Owner

bugra commented Sep 18, 2014

I was not aware of that library, thanks for dropping note, core.matrix seems a really great library!
Generally, I did not want to use a matrix library as a dependency because all of the computation other than training data and test data is specifically is done 1-D vector operations. That being said, I wanted do provide some util functions based on pairwise distance matrix if one first wants to reduce dimensionality first(like PCA or maybe MDS), core.matrix seems perfect for that.

If you have a pull request, feel free, they are more than welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants