Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1Password Importer not importing OTP Entries #71

Open
drrk opened this issue Dec 8, 2022 · 3 comments
Open

1Password Importer not importing OTP Entries #71

drrk opened this issue Dec 8, 2022 · 3 comments

Comments

@drrk
Copy link

drrk commented Dec 8, 2022

I'm trying to import from a 1Password 1pif file, but the OTP entries are not being brought across. I have checked and they are in the 1pif file.

I'm quite following how the importer works, so not able to provide any possible solutions, but will continue to look at update if I can.

Sorry for the lack of detail in the bug report.

@perry-mitchell
Copy link
Member

I don't recall, but it may be so that OTP items were not implemented in the import process yet. This could be added.

@drrk
Copy link
Author

drrk commented Dec 9, 2022

It does look like it - am I right that

function mapTreeLevelToVault(parentVaultItem, treeLevel) {
needs updating to map the OTP entry in the 1Password data to the Buttercup Vault otp entry? I can investigate if I work that out and do some testing.

@perry-mitchell
Copy link
Member

Yeah I think you're on the money there. One would need to detect an OTP property on the 1PW entry and create an associated property on the Buttercup side setting the property value type to be OTP. There's a type enum for this in the core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants