Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating new address on multi-device wallet sends a generic chat notification #418

Open
tarmo888 opened this issue Mar 5, 2019 · 2 comments

Comments

@tarmo888
Copy link
Member

tarmo888 commented Mar 5, 2019

Steps:

  1. Create multi-device wallet (laptop + phone).
  2. Close Android app.
  3. Generate new address on laptop.
  4. Repeat from step 2.

Result:
Generic message (just like the one when somebody sent message in chat) pops up on Android phone.

Expected:
No notification at all or notification that new receiving address was generated.

Device:
Windows 10 laptop
Android 9 phone

@tarmo888 tarmo888 changed the title Generating new address on multi-device wallet send a generic notification Generating new address on multi-device wallet sends a generic notification Mar 5, 2019
@tarmo888 tarmo888 changed the title Generating new address on multi-device wallet sends a generic notification Generating new address on multi-device wallet sends a generic chat notification Mar 5, 2019
@tarmo888
Copy link
Member Author

tarmo888 commented Mar 5, 2019

Maybe better notification message would be: "co-signer generated receiving address" or "new receiving address was generated".

@tonyofbyteball
Copy link
Member

That's a side effect of using end-to-end encrypted messaging. The hub (which sends the push notifications) is just a dumb pipe, it can't know the contents of the message and can't decide that it should be filtered.

One possible solution could be having the sending side add a flag that would tell the hub to silence this message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants