Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #defines from assertion logic? #29

Open
drubinstein opened this issue Apr 8, 2018 · 1 comment
Open

Remove #defines from assertion logic? #29

drubinstein opened this issue Apr 8, 2018 · 1 comment

Comments

@drubinstein
Copy link
Contributor

The assertion logic currently uses #defines heavily. Alternatively, we could've made template structs and stick the static_asserts in the structs. You can then use these as default template arguments (similar to enable_if) or as using declarations inside functions or classes.

Evaluate, discuss and implement or invalidate.

@drubinstein drubinstein changed the title Remove #defines Remove #defines? Apr 8, 2018
@drubinstein drubinstein changed the title Remove #defines? Remove #defines from assertion logic? Apr 8, 2018
@calebzulawski
Copy link
Owner

For now, I've at least renamed them from ASSERT_(condition) to COTILA_DETAIL_ASSERT_(condition) to avoid any macro name reuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants