Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly parses CSS "propertyName" on qtip2, resulting in failure to detect excludeProperties "behavior" attribute #9

Open
bs-thomas opened this issue Feb 16, 2018 · 1 comment

Comments

@bs-thomas
Copy link

I believe there are probably more libraries having this problem, but it's not parsing the CSS correct.
(1) dist/jquery.qtip.css
(2) dist/jquery.qtip.min.css

The two above files were unable to avoid the "behavior" attribute. Putting a console.log on css-url-rewriter.js:46 for the variable "propertyName" tells me that it has not parsed the CSS correctly.

It returns "http" as "propertyName" when using (1)
It returns "{cursor" as "propertyName" when using (2)

I'm using version 0.1.3

Thanks!

bs-thomas added a commit to bs-thomas/css-url-rewriter that referenced this issue Feb 16, 2018
Issue callumlocke#9 Fix parsing issues on some border line cases (qtip)
@bs-thomas
Copy link
Author

I revised the regex patterns a bit to make them more robust to cover a larger variety of use-cases. Hopefully if it's fine you can merge in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant