Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added action description in claim email #297

Closed
wants to merge 1 commit into from

Conversation

MatheusBuss
Copy link
Contributor

What issue does this PR close

Closes #292

Changes Proposed ( a list of new changes introduced by this PR)

Add the action name to the claim email

How to test ( a list of instructions on how to test this PR)

  1. Insert a claim into the local dev database
  2. Run iex -S mix phx.server
  3. Send an email locally (Run
 #{local_claim_id} |> Cambiatus.Objectives.get_claim() |> elem(1) |> CambiatusWeb.Email.claim()

Note: Replace #{local_claim_id} with a valid claim id in the local databse)
5. Got to the local mail box (http://localhost:4000/dev/mailbox)
6. Check the claim email

@MatheusBuss
Copy link
Contributor Author

@lucca65 @NeoVier @juramos-2020 I've just added the claim name into the first line of the email (other than the greeting). But I think this may not be ideal since, some actions have really long names.

I have two suggestions as to how to make this. On the line I placed or above the reward amount. What do you guys think? Perhaps we could do something else entirely.

image

@henriquecbuss
Copy link
Member

I vote on above the reward. Maybe it could be bold (maybe the reward should be bold as well?), and maybe increase the font-size a little, since the contrast is pretty low for this font color and background combination:

image

Even making it bold and larger, I don't think it would have enough contrast. But I don't know if it's too big of a deal to not reach contrast goals in this case, I think we can keep these colors

@juramos-2020
Copy link

juramos-2020 commented Sep 6, 2022

OI @MatheusBuss também gosto de deixar dentro da área verde, acima de recompensa. E concordo com o @NeoVier, podemos deixar tanto a ação como a recompensa em negrito, e manter um espaçamento de 24px entre essas duas informações.

Uma outra sugestão também seria manter essas informações na área branca da seguinte forma:

(logo)

Olá Teste,

Your claim on the actions was approved!
(espaçamento)

Ação: This could be where places our really long action names.....
(espaçamento)

Agradecemos sua contribuição na teste, aqui está sua recompensa!


E se seguirmos essa segunda sugestão, podemos manter a ideia de colocar o "reward" em negrito também.

@MatheusBuss
Copy link
Contributor Author

Oi pessoal, desculpa a demora, mas ontem passei o dia repousando. De qualquer jeito, fiz um template com cada uma das sugestões.

Para a sugestão de colocar a ação na área branca eu coloquei em cinza porque achei que ficou melhor com o contraste.

Entre as duas, prefiro colocar a ação na área verde mesmo. Se acharem que ficou bom já faço dessa maneira. Se quiserem mais alguma alteração talvez seja melhor mover para o Figma, pra acelerar o processo.

image

@lucca65
Copy link
Member

lucca65 commented Jul 11, 2023

closing this for now, as its mostly out of context. We can reopen if needed

@lucca65 lucca65 closed this Jul 11, 2023
@lucca65 lucca65 deleted the enhancement/add-info-to-claim-email branch July 11, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add info to claim email
4 participants