Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement proposal: companions and summonable creatures #121

Open
bw-mutley opened this issue Jan 2, 2022 · 5 comments
Open

Enhancement proposal: companions and summonable creatures #121

bw-mutley opened this issue Jan 2, 2022 · 5 comments

Comments

@bw-mutley
Copy link
Contributor

Hi there, Mark. I got some days to work on this project, so I thought about some improvements. One of them is to include a compiled list of companions and summonable creatures in a similar way it is done to druid shapes. It would be a matter of including a few lines to make_sheets.py.
Also, I would like to ask you which issues are real priorities, it seens like the issues list is not updated. Let me know how can I be of help.

@canismarko
Copy link
Owner

That sounds great! And I agree, should be straightforward.

#88 could use a fix. #102 would be good, but I don't know if it gets used much. I really would like to get #75, but I don't know if a solution to that one exists.

Thanks for your efforts.

@bw-mutley
Copy link
Contributor Author

bw-mutley commented Feb 4, 2022

Hi Mark, I've just made 4 pull requests - sorry if it is 'messy', I don't know how to make just a single one since the changes were in different folders. I've included a small report of changes in one of the commits. I've tested them using .tex and .html forms, but not epub. Let me know if any issues.

==EDIT, 02/16==
Seens like you didn't have time to check the pull requests. I've made some other improvements. This time I added Carrying Weight and capacity to Character class. I will wait for you to see what is better at this time, maybe we should cancel the pull request and make a single update. Let me know when it is a better time for you. Best regards.

@canismarko
Copy link
Owner

@bw-mutley yeah we just had a baby so things have been hectic. Can you let me know which of the 4 PR's I should look at? I can work on it while baby is napping on me at some point.

Thanks!

@bw-mutley
Copy link
Contributor Author

Hey Mark! Congratulations for the baby!
As for the pull requests: I did it wrong, there were changes in 4 folders and I didn't know how to proceed so ended making 4 requests. I guess we can cancel and I pull a single one including other things I've done after this one. Let me know what is best and I will organize things here.

@canismarko
Copy link
Owner

Thanks!

I'd prefer to have 1 PR, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants