From a7cbfbf789a5d60cab413b5774626b67771e7dc1 Mon Sep 17 00:00:00 2001
From: Claudiu Belu <claudiu.belu@canonical.com>
Date: Fri, 11 Oct 2024 07:26:36 +0000
Subject: [PATCH] Adds falcosidekick to the integration test

The falcosidekick helm chart doesn't pass any arguments to
falcosidekick, but we've set the --help as the default argument, meaning
that it won't start up as intended.

falcosidekick helm chart also creates a deployment with
readOnlyRootFilesystem=True set, which means that Pebble won't be able
to copy its necessary files. We can use the Pebble mutating webhook to
solve this issue.
---
 falcosidekick/2.29.0/rockcraft.yaml |  4 +-
 tests/integration/test_falco.py     | 66 +++++++++++++++++++++++++++++
 2 files changed, 67 insertions(+), 3 deletions(-)

diff --git a/falcosidekick/2.29.0/rockcraft.yaml b/falcosidekick/2.29.0/rockcraft.yaml
index 41510cf..18980fe 100644
--- a/falcosidekick/2.29.0/rockcraft.yaml
+++ b/falcosidekick/2.29.0/rockcraft.yaml
@@ -28,12 +28,10 @@ services:
     startup: enabled
     # falcosidekick user and group is created, and the workdir is set in its home.
     # https://github.com/falcosecurity/falcosidekick/blob/2.29.0/Dockerfile#L14
-    command: "/home/falcosidekick/app/falcosidekick [ --help ]"
+    command: "/home/falcosidekick/app/falcosidekick"
     on-success: shutdown
     on-failure: shutdown
 
-entrypoint-service: falcosidekick
-
 parts:
   # https://github.com/falcosecurity/falcosidekick/blob/2.29.0/Dockerfile#L8
   falcosidekick-user:
diff --git a/tests/integration/test_falco.py b/tests/integration/test_falco.py
index 8c37f28..61ea521 100644
--- a/tests/integration/test_falco.py
+++ b/tests/integration/test_falco.py
@@ -34,6 +34,30 @@ def _get_event_generator_helm_cmd():
     )
 
 
+def _get_falcosidekick_helm_cmd():
+    falcosidekick_rock = env_util.get_build_meta_info_for_rock_version(
+        "falcosidekick", "2.29.0", "amd64"
+    )
+
+    images = [
+        k8s_util.HelmImage(falcosidekick_rock.image),
+    ]
+
+    set_configs = [
+        "webui.enabled=true",
+    ]
+
+    return k8s_util.get_helm_install_command(
+        "falcosidekick",
+        "falcosidekick",
+        namespace="falco",
+        repository="https://falcosecurity.github.io/charts",
+        images=images,
+        set_configs=set_configs,
+        split_image_registry=True,
+    )
+
+
 def _get_falco_helm_cmd(falco_version: str):
     falco_rock = env_util.get_build_meta_info_for_rock_version(
         "falco", falco_version, "amd64"
@@ -73,6 +97,33 @@ def _get_falco_helm_cmd(falco_version: str):
     )
 
 
+def _assert_falcosidekick_up(instance: harness.Instance):
+    # Assert that falcosidekick is responsive. It has a ping method, to which we should get pong.
+    # The falcosidekick image does not have curl or wget, but the falco image does.
+    LOG.info("Checking if Falco detected irregularities.")
+    process = instance.exec(
+        [
+            "k8s",
+            "kubectl",
+            "--namespace",
+            "falco",
+            "exec",
+            f"{constants.K8S_DAEMONSET}/falco",
+            "--",
+            "curl",
+            "-s",
+            "http://falcosidekick:2801/ping",
+        ],
+        check=True,
+        capture_output=True,
+        text=True,
+    )
+
+    assert (
+        "pong" in process.stdout
+    ), "Expected falcosidekick to respond with pong to ping."
+
+
 def _assert_falco_logs(instance: harness.Instance):
     # Falco should have noticed the unexpected behaviour from the event-generator, and it should
     # have logged these events to stdout by default.
@@ -120,12 +171,26 @@ def _assert_falco_logs(instance: harness.Instance):
 
 @pytest.mark.parametrize("image_version", ["0.38.2", "0.39.0"])
 def test_integration_falco(function_instance: harness.Instance, image_version):
+    # falcosidekick has readOnlyRootFilesystem=True, which means Pebble won't be able
+    # to copy its necessary files. This mutating webhook solves this issue by adding
+    # an emptydir volume to Pods for Pebble to use.
+    k8s_util.install_mutating_pebble_webhook(function_instance)
+
     # Deploy Falco helm chart and wait for it to become active.
     function_instance.exec(_get_falco_helm_cmd(image_version))
 
+    # Deploy falcosidekick helm chart and wait for it to become active.
+    function_instance.exec(_get_falcosidekick_helm_cmd())
+
     # Wait for the daemonset to become Active.
     k8s_util.wait_for_daemonset(function_instance, "falco", "falco", retry_times=10)
 
+    # Wait for the deployments to become Active.
+    for deployment in ["falcosidekick", "falcosidekick-ui"]:
+        k8s_util.wait_for_deployment(
+            function_instance, deployment, "falco", retry_times=10
+        )
+
     # Deploy event-generator for Falco and wait for it to become active.
     function_instance.exec(_get_event_generator_helm_cmd())
 
@@ -140,3 +205,4 @@ def test_integration_falco(function_instance: harness.Instance, image_version):
     )
 
     _assert_falco_logs(function_instance)
+    _assert_falcosidekick_up(function_instance)