-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebrand /iot/smart-displays #14538
Rebrand /iot/smart-displays #14538
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature-rebrand-iot #14538 +/- ##
======================================================
Coverage ? 69.64%
======================================================
Files ? 120
Lines ? 3419
Branches ? 1178
======================================================
Hits ? 2381
Misses ? 1013
Partials ? 25 |
0398392
to
db54626
Compare
db54626
to
5e158ab
Compare
5e158ab
to
dae8ba9
Compare
ty @britneywwc ! :) a couple assets changes, sorry! For this section, for smaller screens:
For this section, for smaller screens:
|
Thanks Britney looks great! Some comments:
|
Thanks for the changes @britneywwc, looks great! Adding +1 |
ty @britneywwc and sorry for late pr review ;-; I just had a couple questions:
All else is good tho! |
@mattea-turic Thanks for the review. I'm not sure about the image dimensions for Ubuntu Core and Frame, maybe something similar to the images that are being used in the Hero Signpost? Either that or I could hide the logos on smaller screens. |
Got it, I've added a resized version for Ubuntu Core and for Frame. Hopefully this'll work better now :) |
7a3695e
to
0bcfd7e
Compare
Looks great @britneywwc ! Just a few tiny corrections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Approved.
Done
QA
Issue / Card
Fixes WD-16639
Screenshots
[If relevant, please include a screenshot.]
Help
QA steps - Commit guidelines