Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand /iot/smart-displays #14538

Merged

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Dec 4, 2024

Done

  • Apply rebranding on /internet-of-things/smart-displays
  • No changes to content, only design

QA

Issue / Card

Fixes WD-16639

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

@webteam-app
Copy link

@britneywwc britneywwc changed the base branch from feature-rebrand-iot to main December 4, 2024 12:19
@britneywwc britneywwc marked this pull request as draft December 4, 2024 12:20
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature-rebrand-iot@dae8ba9). Learn more about missing BASE report.
Report is 21 commits behind head on feature-rebrand-iot.

Additional details and impacted files
@@                  Coverage Diff                   @@
##             feature-rebrand-iot   #14538   +/-   ##
======================================================
  Coverage                       ?   69.64%           
======================================================
  Files                          ?      120           
  Lines                          ?     3419           
  Branches                       ?     1178           
======================================================
  Hits                           ?     2381           
  Misses                         ?     1013           
  Partials                       ?       25           

@britneywwc britneywwc force-pushed the rebrand-iot-smart-displays branch from 0398392 to db54626 Compare December 5, 2024 07:50
@britneywwc britneywwc changed the base branch from main to feature-rebrand-iot December 5, 2024 07:51
@britneywwc britneywwc force-pushed the rebrand-iot-smart-displays branch from db54626 to 5e158ab Compare December 5, 2024 07:51
@britneywwc britneywwc closed this Dec 5, 2024
@britneywwc britneywwc force-pushed the rebrand-iot-smart-displays branch from 5e158ab to dae8ba9 Compare December 5, 2024 08:00
@mattea-turic
Copy link
Collaborator

mattea-turic commented Dec 5, 2024

ty @britneywwc ! :) a couple assets changes, sorry!

For this section, for smaller screens:
Screenshot 2024-12-05 at 10 33 13

  • Could you maintain the images pls?

For this section:
Screenshot 2024-12-05 at 10 24 59

  • The logos look a lil small to me so I've uploaded new ones in the assets server (they've got the suffix "-updated". The container for these is also a lot smaller, so it should look good on smaller screens to now

For this section:
Screenshot 2024-12-05 at 10 29 34

  • The logos look too big to me, so I've added new assets, again with the suffix "-updated"
  • Something strange is going on with this section on smaller screens btw:
Screenshot 2024-12-05 at 10 35 04

For this section, for smaller screens:
Screenshot 2024-12-05 at 10 36 20

  • Could you maintain the images pls

@eliman11
Copy link

eliman11 commented Dec 5, 2024

Thanks Britney looks great! Some comments:

  • Fix typo under 'Get started now with Ubuntu Core and Frame' to "Your graphical application will instantly run in full screen with all input modalities seamlessly on all hardware."
  • Link 'More information about Ubuntu Frame graphics support ›' to https://discourse.ubuntu.com/t/where-does-ubuntu-frame-work/23193
  • 'Get in touch ›' under 'Learn how we can get your device to market for you' to link to contact modal instead of page
  • Change h5s into h3 without changing styling
Screenshot 2024-12-05 at 10 42 15
  • Just got a reply from the stakeholder - could we change 'deep learning' into 'deep learning hardware' under 'Faster innovation'? Marked as a suggestion on copydoc if it's easier to spot that way

@eliman11
Copy link

eliman11 commented Dec 9, 2024

Thanks for the changes @britneywwc, looks great! Adding +1

@mattea-turic
Copy link
Collaborator

mattea-turic commented Dec 10, 2024

ty @britneywwc and sorry for late pr review ;-;

I just had a couple questions:

  • Would you be able to use the wrap variant here for the equal heights row so that the aspect ratio self-adjusts for smaller screens, and so tablets use a 2x2 layout? – and same thing for the "ready for all boards..." section
Screenshot 2024-12-10 at 00 15 29

And then for this section:
Screenshot 2024-12-10 at 00 18 59
Screenshot 2024-12-10 at 00 19 50

  • Could you reduce the size of the images, particularly for smaller screens? With the previous asset I provided, the logos were smaller but there was a lot of whitespace. Now, there is less whitespace, but the logos are v big :') is there a format of the logos I could send over that would work better for both?

All else is good tho!

@britneywwc
Copy link
Contributor Author

@mattea-turic Thanks for the review. I'm not sure about the image dimensions for Ubuntu Core and Frame, maybe something similar to the images that are being used in the Hero Signpost? Either that or I could hide the logos on smaller screens.

@mattea-turic
Copy link
Collaborator

@mattea-turic Thanks for the review. I'm not sure about the image dimensions for Ubuntu Core and Frame, maybe something similar to the images that are being used in the Hero Signpost? Either that or I could hide the logos on smaller screens.

Got it, I've added a resized version for Ubuntu Core and for Frame. Hopefully this'll work better now :)

templates/internet-of-things/smart-displays.html Outdated Show resolved Hide resolved
templates/internet-of-things/smart-displays.html Outdated Show resolved Hide resolved
templates/internet-of-things/smart-displays.html Outdated Show resolved Hide resolved
templates/internet-of-things/smart-displays.html Outdated Show resolved Hide resolved
templates/internet-of-things/smart-displays.html Outdated Show resolved Hide resolved
templates/internet-of-things/smart-displays.html Outdated Show resolved Hide resolved
templates/internet-of-things/smart-displays.html Outdated Show resolved Hide resolved
@muhammad-ali-pk
Copy link
Contributor

Looks great @britneywwc ! Just a few tiny corrections.

Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Approved.

@britneywwc britneywwc merged commit ffdfedf into canonical:feature-rebrand-iot Dec 12, 2024
15 checks passed
@britneywwc britneywwc deleted the rebrand-iot-smart-displays branch December 12, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants