Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand /landscape #14540

Conversation

immortalcodes
Copy link
Member

@immortalcodes immortalcodes commented Dec 5, 2024

Done

  • Rebranded /landscape landing page

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • View the site locally in your web browser at: http://0.0.0.0:8001/
    • Be sure to test on mobile, tablet and desktop screen sizes
  • Demo
  • Design
  • Copydoc

Issue / Card

Fixes # WD-16834

Help

QA steps - Commit guidelines

@webteam-app
Copy link

@immortalcodes immortalcodes marked this pull request as ready for review December 5, 2024 09:45
@mattea-turic
Copy link
Collaborator

ty @immortalcodes , only a couple things from me!

For this section:
Screenshot 2024-12-05 at 09 58 03

  • <br> after "control" pls

For this section (smaller screens):
Screenshot 2024-12-05 at 10 05 04

  • hr isn't needed above the person's name, and the shallow from the quote itself can be removed

For this section:
Screenshot 2024-12-05 at 10 00 14

  • <br> after "Landscape" – or if that doesn't fit, then after "an"
  • could you also wrap the image in a shallow and
  • add a hr above the first list item

For this section:
Screenshot 2024-12-05 at 10 08 06

  • CTA is misaligned

@eliman11
Copy link

eliman11 commented Dec 5, 2024

Thanks @immortalcodes! One question on the 'Get Landscape' CTAs throughout the page - it links to the /pricing page, which will be changed to /compare instead. Is this something we'd need to change on the index page now?

Also:

  • Remove chevron > in the CTA
Screenshot 2024-12-05 at 11 35 18
  • "Ubuntu pro customers include" heading should be h2 -> is this something to also request from Vanilla?
Screenshot 2024-12-05 at 11 50 21
  • Remove h2 tag from CTA link
Screenshot 2024-12-05 at 11 51 58

@immortalcodes
Copy link
Member Author

immortalcodes commented Dec 6, 2024

Thanks @immortalcodes! One question on the 'Get Landscape' CTAs throughout the page - it links to the /pricing page, which will be changed to /compare instead. Is this something we'd need to change on the index page now?

Also:

  • Remove chevron > in the CTA
Screenshot 2024-12-05 at 11 35 18 * [ ] "Ubuntu pro customers include" heading should be h2 -> is this something to also request from Vanilla? Screenshot 2024-12-05 at 11 50 21 * [ ] Remove h2 tag from CTA link Screenshot 2024-12-05 at 11 51 58
  • For the links, yes they need to be changed if we are moving the pricing page, this is not going to live so we can add broken links and qa them later when pages are up, or we can add a redirect if both the pages are staying.

  • For the last section, are they not H2s if not H2s are they paragraphs with H2 styles?

@mattea-turic
Copy link
Collaborator

thanks @immortalcodes ! literally just two v small change to be made, if possible, so I'll +1:

this section is missing a regular bottom padding:
Screenshot 2024-12-06 at 12 26 06

could the break after "scale" on smaller screens be removed pls, as it ends up with the sentence occupying 3 lines:
Screenshot 2024-12-06 at 12 27 17

templates/landscape/index.html Outdated Show resolved Hide resolved
templates/landscape/index.html Outdated Show resolved Hide resolved
templates/landscape/index.html Outdated Show resolved Hide resolved
templates/landscape/index.html Outdated Show resolved Hide resolved
templates/landscape/index.html Show resolved Hide resolved
templates/landscape/index.html Show resolved Hide resolved
@eliman11
Copy link

eliman11 commented Dec 6, 2024

  • For the links, yes they need to be changed if we are moving the pricing page, this is not going to live so we can add broken links and qa them later when pages are up, or we can add a redirect if both the pages are staying.
  • For the last section, are they not H2s if not H2s are they paragraphs with H2 styles?

Noted on the links, will keep an eye out when the page goes into development. You're right - the CTA block should remain as H2s so please leave as is.

One more comment - would you mind adding 'Explore IoT device management' as a primary CTA under 'Discover Landscape
for IoT device management' and remove 'the' from the link CTA 'Access the whitepaper on patching IoT devices ›'? I've edited the copydoc and will tag you in that section on Figma to clarify. Thank you!

@eliman11
Copy link

eliman11 commented Dec 9, 2024

Thanks for the changes @immortalcodes! Adding +1

@immortalcodes immortalcodes changed the base branch from main to feature-rebrand-landscape December 10, 2024 04:12
@immortalcodes immortalcodes merged commit 7338fe6 into feature-rebrand-landscape Dec 10, 2024
29 checks passed
@immortalcodes immortalcodes deleted the WD-16834-dev-rebrand-landscape-landing-page branch December 10, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants